-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Tuesday, April 15, 2014 8:04 PM To: Bard Liao Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; lars@metafoo.de; Flove; Oder Chiou; Gustaw Lewandowski Subject: Re: [PATCH v6] ASoC: add RT286 CODEC driver
On Mon, Apr 14, 2014 at 01:59:30PM +0800, bardliao@realtek.com wrote:
+static unsigned int rt286_hw_read(struct snd_soc_codec *codec,
unsigned int reg)+{
+static int rt286_hw_write(struct snd_soc_codec *codec,
unsigned int reg, unsigned int value) {To repeat what's been said before if you are implementing register I/O you *MUST* use regmap to do this. What's not been clear is if this device has a control interface that looks enough like a register map to be implemented like one but since we're just guessing based on a combination of the code and the HDA spec it's not entirely clear.
I am a little bit confused about it. I thought you told me not using regmap. Actually, I don't know how to use dapm without implementing register I/O. Can I just convert rt286_hw_read/write to regmap?
------Please consider the environment before printing this e-mail.