Hi Padma,
On 16/12/14 04:16, Padma Venkat wrote:
Hi Sylwester,
I need some more thought about interaction between the clk API calls on the clocks being exposed and the ASoC calls into sound/soc/samsung/i2s.c. I'm sending teh patches for review though to avoid any waste of time should it turn out the direction taken is wrong.
This whole series definitely needs more testing, so far I only tested it on Odroid X2, with the I2S working in slave mode.
your patches looks good to me. I did basic playback and capture test of your patches with i2s in master mode on exynos7. I also added secondary dai for testing and verified playback. But I think some more testing required to check the serialization of registers. Tried aplay with front dai in background and with secondary dai in the foreground. But due to one issue on my system backend playback not working.
Thanks a lot for testing! I also tested concurrent playback with the primary and the secondary DAI (on Exynos4412), enabling the secondary DAI with a bit hackish patch as in this branch: git://linuxtv.org/snawrocki/samsung.git sound/odroidx2-simple-card-v2 I'm planning to do necessary changes to enable the secondary DAI properly with simple-card, once we're done with this series.