Re: [alsa-devel] [PATCH v2 1/7] arm: put types.h in uapi

On Mon, Jan 09, 2017 at 12:33:02PM +0100, Arnd Bergmann wrote:

On Friday, January 6, 2017 10:43:53 AM CET Nicolas Dichtel wrote:

...

diff --git a/arch/arm/include/asm/types.h b/arch/arm/include/asm/types.h index a53cdb8f068c..c48fee3d7b3b 100644 --- a/arch/arm/include/asm/types.h +++ b/arch/arm/include/asm/types.h @@ -1,40 +1,6 @@ #ifndef _ASM_TYPES_H #define _ASM_TYPES_H

-#include <asm-generic/int-ll64.h>

...

...

-#define __UINTPTR_TYPE__ unsigned long -#endif +#include <uapi/asm/types.h>

#endif /* _ASM_TYPES_H */

Moving the file is correct as far as I can tell, but the extra #include is not necessary here, as the kernel will automatically search both arch/arm/include/ and arch/arm/include/uapi/.

Indeed, I'd like to see the include/asm file gone.