On 08/06/16 01:19, Russell King - ARM Linux wrote:
It'll pick up that as the DT device to hang things off which I'd expect to be the desired outcome given that this is a very similar situation to the MFD situation. I've not been following the full thread so there is probably context I'm missing here...
Okay, and that sounds to me like a very reasonable thing to want to happen - so that the audio side can be clearly identified as being coupled with the video side.
So, I'm not seeing a problem with my suggestion... I'm actually more reasons why it's a good thing to want.
Ok, so getting back to this comment:
- priv->audio_pdev = platform_device_register_data(
dev, HDMI_CODEC_DRV_NAME, PLATFORM_DEVID_AUTO,&codec_data, sizeof(codec_data));I'd much prefer that this was a child of the I2C device, which will show the relationship between this virtual platform device and the device which it's associated with. That can be done via platform_device_register_full().
The platform_device_register_data() sets the parent of the registered platform device according to the first parameter, the tda998x i2c-client in this case. Is there some reason why I should use platform_device_register_full() and should I set parent to something else than the tda998x i2c device?
BR, Jyri