Dne 07. 03. 19 v 9:11 Kailang napsal(a):
Hi Jaroslav,
I need to check with Intel chrome audio team for the name change. But chrome OS used 'alc-sense-combo' for early patch file.
But with your patch, the ALC225_FIXUP_HEADSET_JACK and ALC295_FIXUP_CHROME_BOOK do a different thing, so it's not a simple replacement. Your chrome book fixup is not universal, so it should be distinguished in my opinion.
Also, please, inline your patches or use ;git send-email' command to send your commit to this ML for a review.
Thanks, Jaroslav
It also need to add this patch.
Oh! Sorry! I sent it with HTML mode. I need to resend again for TXT mode.
BR, Kailang
-----Original Message----- From: Jaroslav Kysela perex@perex.cz Sent: Thursday, March 7, 2019 4:03 PM To: Kailang kailang@realtek.com; Takashi Iwai (tiwai@suse.de) tiwai@suse.de Cc: (alsa-devel@alsa-project.org) alsa-devel@alsa-project.org Subject: Re: [alsa-devel] ChromeBook machine will lose MIC JD
Dne 07. 03. 19 v 8:56 Kailang napsal(a):
Hi Takashi,
Attach patch will solve the issue for Mic JD lose.
- {.id = ALC225_FIXUP_HEADSET_JACK, .name = "alc-sense-combo"},
- {.id = ALC295_FIXUP_CHROME_BOOK, .name = "alc-sense-combo"},
Define another name here like 'alc-chrome-book' and don't remove the previous model name 'alc-sense-combo'.
Jaroslav-- Jaroslav Kysela perex@perex.cz Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
------Please consider the environment before printing this e-mail.