31 Mar
2014
31 Mar
'14
9:47 p.m.
On 03/31/2014 01:23 PM, Thierry Reding wrote:
On Mon, Mar 31, 2014 at 12:38:16PM -0600, Stephen Warren wrote: [...]
diff --git a/sound/soc/codecs/alc5632.c b/sound/soc/codecs/alc5632.c
[...]
+static const struct of_device_id alc5632_of_match[] = {
- { .compatible = "realtek,alc5632", },
- { }
+}; +MODULE_DEVICE_TABLE(of, alc5632_of_match);
Doesn't this need #ifdef protection to prevent warnings about this being unused for !OF?
What I really meant to do was reference these tables directly rather than using of_match_ptr().
There seems to be a mix of ifdef'ing the table and using of_match_ptr() vs. the other way around in ASoC. Mark, do you have a preference which way to go?