On 21/02/2022 15:38, Mark Brown wrote:
On Mon, Feb 21, 2022 at 01:10:36PM +0000, Srinivas Kandagatla wrote:
For SoundWire Frame sync to be generated correctly we need both MCLK and MCLKx2 (npl). Without pm runtime enabled these two clocks will remain on, however after adding pm runtime support its possible that NPl clock could be turned off even when SoundWire controller is active.
Fix this by enabling mclk and npl clk when SoundWire clks are enabled.
A lot of these commit messages sound like earlier patches in the series introduced bugs which isn't going to be ideal for bisection.
Yes that is true, I did think about sending this as a fix.
Adding a fix tag would not really make any functional difference as we will be hitting the issue only when we enable pm runtime in codec and SoundWire controller, so I did add this as part of pm runtime patches.
Without runtime pm the clocks are left always on, so it worked so far.
--srini