Re: Implicit feedback on BOSS GT-1, the saga continues...

9 Apr 2021

Thanks, Lucas, every device may be different so maybe Mike's BOSS GT-1
works without the capture quirk whereas your Roland D-05 needs it and won't
work without it.
But you did the good work testing it.
I'm glad you two are able to coordinate/collaborate in this Roland thing. I
wasn't able to make the Pioneer users coordinate so far, and it's implicit
feedback problems too. Only heard from Ard van Breemen, so far. Apparently
he hasn't got any problems with his DDJ-SX3, it runs for days on end, and
he isn't able to test kernel code for now.
Regards,
Geraldo
On Fri, Apr 9, 2021 at 12:57 AM Lucas jaffa225man@gmail.com wrote:
...
Okay, thanks!  I'll try it next.  For now, I did use the disabled block
"(false)" test, without worry due to you giving me your quite speedy build
method, although I do still reboot.
Anyway, I've proven my assertion that capture fails for the D-05 when I
have its capture_implicit_fb_quirks[] line commented out.  This is a patch
for the current state of what works perfectly for playback and capture on
my D-05.  Sorry it includes some other patches I've applied due to
unrelated UA-101 Takashi suggestions.  Merely removing the suggested
comment from its capture quirk table line (as shown here) gets the Roland
Boutique D-05 working for capture.  I don't understand why, but this works,
& not without it:
diff -Nurp linux-5.11.9.orig/sound/usb/endpoint.c
linux-5.11.9.roland-mike-oliphant/sound/usb/endpoint.c

--- linux-5.11.9.orig/sound/usb/endpoint.c 2021-03-24 05:54:19.000000000
-0500
+++ linux-5.11.9.roland-mike-oliphant/sound/usb/endpoint.c 2021-04-08
21:10:49.388889365 -0500
@@ -1375,7 +1375,7 @@ int snd_usb_endpoint_start(struct snd_us
  if (!ep_state_update(ep, EP_STATE_STOPPED, EP_STATE_RUNNING))
  goto __error;

if (snd_usb_endpoint_implicit_feedback_sink(ep)) {


if (false) { //(snd_usb_endpoint_implicit_feedback_sink(ep)) {
for (i = 0; i < ep->nurbs; i++) {
struct snd_urb_ctx *ctx = ep->urb + i;
list_add_tail(&ctx->ready_list, &ep->ready_playback_urbs);

diff -Nurp linux-5.11.9.orig/sound/usb/implicit.c
linux-5.11.9.roland-mike-oliphant/sound/usb/implicit.c
--- linux-5.11.9.orig/sound/usb/implicit.c 2021-04-01 20:55:06.079399075
-0500
+++ linux-5.11.9.roland-mike-oliphant/sound/usb/implicit.c 2021-04-08
22:29:22.139680224 -0500
@@ -71,27 +71,149 @@ static const struct snd_usb_implicit_fb_
   .ep_num = 0x84, .iface = 0 }, /* MOTU MicroBook II */
/* No quirk for playback but with capture quirk (see below) */

IMPLICIT_FB_SKIP_DEV(0x0582, 0x0130), /* BOSS BR-80 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0171),   /* BOSS RC-505 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0185), /* BOSS GP-10 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0189), /* BOSS GT-100v2 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x01d6), /* BOSS GT-1 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x01d8), /* BOSS Katana */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x01e5), /* BOSS GT-001 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0203),   /* BOSS AD-10 */


IMPLICIT_FB_SKIP_DEV(0x0582, 0x00a6), /* Roland JUNO-G */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00a9), /* Roland MC-808 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00ad), /* Roland SH-201 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00b2), /* Roland VG-99 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00b3), /* Roland VG-99 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00c2), /* Roland SonicCell */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00c4), /* Edirol M-16DX */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00c5), /* Roland SP-555 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00c7), /* Roland V-Synth GT */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00d1), /* Roland Music Atelier */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00da), /* BOSS GT-10 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00db), /* BOSS GT-10 Guitar Effects

Processor */

IMPLICIT_FB_SKIP_DEV(0x0582, 0x00dc), /* BOSS GT-10B */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00de), /* Roland Fantom-G */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00eb), /* Roland VS-100 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00f8), /* Roland JUNO Series */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00fc), /* Roland VS-700C */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00fd), /* Roland VS-700 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00fe), /* Roland VS-700 M1 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x00ff), /* Roland VS-700 M2 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0100), /* Roland VS-700 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0101), /* Roland VS-700 M2 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0102), /* Roland VB-99 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0109), /* BOSS eBand JS-8 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0111), /* Roland GAIA SH-01 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0113), /* BOSS ME-25 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0114), /* Roland SD-50 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0117), /* Roland VS-20 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0119), /* Roland OCTAPAD SPD-30 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x011c), /* Roland Lucina AX-09 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x011e), /* BOSS BR-800 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0120), /* Roland OCTA-CAPTURE */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0121), /* Roland OCTA-CAPTURE */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0123), /* Roland JUNO-Gi */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0124), /* Roland M-300 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0127), /* Roland GR-55 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x012b), /* Roland DUO-CAPTURE */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x012f), /* Roland QUAD-CAPTURE */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0130), /* BOSS BR-80 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0132), /* Roland TRI-CAPTURE */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0134), /* Roland V-Mixer */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0138), /* BOSS RC-300 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x013a), /* Roland JUPITER-80 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x013e), /* Roland R-26 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0145), /* Roland SPD-SX */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x014b), /* BOSS eBand JS-10 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x014d), /* BOSS GT-100 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0150), /* Roland TD-15 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0151), /* Roland TD-11 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0154), /* Roland JUPITER-50 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0158), /* Roland TD-30 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0159), /* Roland DUO-CAPTURE EX */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x015b), /* Roland INTEGRA-7 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x015d), /* Roland R-88 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0171), /* BOSS RC-505 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x017a), /* Roland VT-3 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x017c), /* Roland TR-8 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0185), /* BOSS GP-10 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x0189), /* BOSS GT-100v2 */
IMPLICIT_FB_SKIP_DEV(0x0582, 0x01b5), /* Roland Boutique Series

Synthesizer */

IMPLICIT_FB_SKIP_DEV(0x0582, 0x01d6), /* BOSS GT-1 */

IMPLICIT_FB_SKIP_DEV(0x0582, 0x01d8), /* BOSS Katana */

IMPLICIT_FB_SKIP_DEV(0x0582, 0x01df), /* Roland Rubix22 */

IMPLICIT_FB_SKIP_DEV(0x0582, 0x01e0), /* Roland Rubix24 */

IMPLICIT_FB_SKIP_DEV(0x0582, 0x01e1), /* Roland Rubix44 */

IMPLICIT_FB_SKIP_DEV(0x0582, 0x01e5), /* BOSS GT-001 */

IMPLICIT_FB_SKIP_DEV(0x0582, 0x01fd), /* Roland Boutique SH-01A */

IMPLICIT_FB_GENERIC_DEV(0x0582, 0x01ff), /* Roland Boutique D-05 */

IMPLICIT_FB_SKIP_DEV(0x0582, 0x0203), /* BOSS AD-10 */
{} /* terminator */


};
/* Implicit feedback quirk table for capture: only FIXED type */
 static const struct snd_usb_implicit_fb_match
capture_implicit_fb_quirks[] = {

IMPLICIT_FB_FIXED_DEV(0x0582, 0x00a6, 0x0d, 0x01), /* Roland JUNO-G */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00a9, 0x0d, 0x01), /* Roland MC-808 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00ad, 0x0d, 0x01), /* Roland SH-201 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00b2, 0x0d, 0x01), /* Roland VG-99 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00b3, 0x0d, 0x01), /* Roland VG-99 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00c2, 0x0d, 0x01), /* Roland SonicCell */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00c4, 0x0d, 0x01), /* Edirol M-16DX */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00c5, 0x0d, 0x01), /* Roland SP-555 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00c7, 0x0d, 0x01), /* Roland V-Synth GT

*/

IMPLICIT_FB_FIXED_DEV(0x0582, 0x00d1, 0x0d, 0x01), /* Roland Music

Atelier */

IMPLICIT_FB_FIXED_DEV(0x0582, 0x00da, 0x0d, 0x01), /* BOSS GT-10 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00db, 0x0d, 0x01), /* BOSS GT-10 Guitar

Effects Processor */

IMPLICIT_FB_FIXED_DEV(0x0582, 0x00dc, 0x0d, 0x01), /* BOSS GT-10B */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00de, 0x0d, 0x01), /* Roland Fantom-G */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00eb, 0x0d, 0x01), /* Roland VS-100 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00f8, 0x0d, 0x01), /* Roland JUNO Series

*/

IMPLICIT_FB_FIXED_DEV(0x0582, 0x00fc, 0x0d, 0x01), /* Roland VS-700C */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00fd, 0x0d, 0x01), /* Roland VS-700 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00fe, 0x0d, 0x01), /* Roland VS-700 M1 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x00ff, 0x0d, 0x01), /* Roland VS-700 M2 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0100, 0x0d, 0x01), /* Roland VS-700 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0101, 0x0d, 0x01), /* Roland VS-700 M2 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0102, 0x0d, 0x01), /* Roland VB-99 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0109, 0x0d, 0x01), /* BOSS eBand JS-8 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0111, 0x0d, 0x01), /* Roland GAIA SH-01

*/

IMPLICIT_FB_FIXED_DEV(0x0582, 0x0113, 0x0d, 0x01), /* BOSS ME-25 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0114, 0x0d, 0x01), /* Roland SD-50 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0117, 0x0d, 0x01), /* Roland VS-20 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0119, 0x0d, 0x01), /* Roland OCTAPAD

SPD-30 */

IMPLICIT_FB_FIXED_DEV(0x0582, 0x011c, 0x0d, 0x01), /* Roland Lucina

AX-09 */

IMPLICIT_FB_FIXED_DEV(0x0582, 0x011e, 0x0d, 0x01), /* BOSS BR-800 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0120, 0x0d, 0x01), /* Roland

OCTA-CAPTURE */

IMPLICIT_FB_FIXED_DEV(0x0582, 0x0121, 0x0d, 0x01), /* Roland

OCTA-CAPTURE */

IMPLICIT_FB_FIXED_DEV(0x0582, 0x0123, 0x0d, 0x01), /* Roland JUNO-Gi */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0124, 0x0d, 0x01), /* Roland M-300 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0127, 0x0d, 0x01), /* Roland GR-55 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x012b, 0x0d, 0x01), /* Roland DUO-CAPTURE

*/

IMPLICIT_FB_FIXED_DEV(0x0582, 0x012f, 0x0d, 0x01), /* Roland

QUAD-CAPTURE */
  IMPLICIT_FB_FIXED_DEV(0x0582, 0x0130, 0x0d, 0x01), /* BOSS BR-80 */

IMPLICIT_FB_FIXED_DEV(0x0582, 0x0132, 0x0d, 0x01), /* Roland TRI-CAPTURE

*/

IMPLICIT_FB_FIXED_DEV(0x0582, 0x0134, 0x0d, 0x01), /* Roland V-Mixer */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0138, 0x0d, 0x01), /* BOSS RC-300 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x013a, 0x0d, 0x01), /* Roland JUPITER-80

*/

IMPLICIT_FB_FIXED_DEV(0x0582, 0x013e, 0x0d, 0x01), /* Roland R-26 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0145, 0x0d, 0x01), /* Roland SPD-SX */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x014b, 0x0d, 0x01), /* BOSS eBand JS-10 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x014d, 0x0d, 0x01), /* BOSS GT-100 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0150, 0x0d, 0x01), /* Roland TD-15 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0151, 0x0d, 0x01), /* Roland TD-11 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0154, 0x0d, 0x01), /* Roland JUPITER-50

*/

IMPLICIT_FB_FIXED_DEV(0x0582, 0x0158, 0x0d, 0x01), /* Roland TD-30 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0159, 0x0d, 0x01), /* Roland DUO-CAPTURE

EX */

IMPLICIT_FB_FIXED_DEV(0x0582, 0x015b, 0x0d, 0x01), /* Roland INTEGRA-7 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x015d, 0x0d, 0x01), /* Roland R-88 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0171, 0x0d, 0x01), /* BOSS RC-505 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x017a, 0x0d, 0x01), /* Roland VT-3 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x017c, 0x0d, 0x01), /* Roland TR-8 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0185, 0x0d, 0x01), /* BOSS GP-10 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x0189, 0x0d, 0x01), /* BOSS GT-100v2 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x01b5, 0x0d, 0x01), /* Roland Boutique

Series Synthesizer */
  IMPLICIT_FB_FIXED_DEV(0x0582, 0x01d6, 0x0d, 0x01), /* BOSS GT-1 */
  IMPLICIT_FB_FIXED_DEV(0x0582, 0x01d8, 0x0d, 0x01), /* BOSS Katana */

IMPLICIT_FB_FIXED_DEV(0x0582, 0x01df, 0x0d, 0x01), /* Roland Rubix22 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x01e0, 0x0d, 0x01), /* Roland Rubix24 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x01e1, 0x0d, 0x01), /* Roland Rubix44 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x01e5, 0x0d, 0x01), /* BOSS GT-001 */
IMPLICIT_FB_FIXED_DEV(0x0582, 0x01fd, 0x0d, 0x01), /* Roland Boutique

SH-01A */

IMPLICIT_FB_FIXED_DEV(0x0582, 0x01ff, 0x0d, 0x01), /* Roland Boutique

D-05 */
  IMPLICIT_FB_FIXED_DEV(0x0582, 0x0203, 0x0d, 0x01), /* BOSS AD-10 */
{} /* terminator */
@@ -278,6 +400,11 @@ static int audioformat_implicit_fb_quirk
  }
  }

///* Don't apply playback quirks for the devices with capture quirk */
//p = find_implicit_fb_entry(chip, capture_implicit_fb_quirks, alts);
//if (p && p->type == IMPLICIT_FB_FIXED)
// return 0; /* no quirk */
/* Generic UAC2 implicit feedback */
if (attr == USB_ENDPOINT_SYNC_ASYNC &&
   alts->desc.bInterfaceClass == USB_CLASS_AUDIO &&


    

Re: Implicit feedback on BOSS GT-1, the saga continues...

Geraldo Nascimento