Re: [PATCH] ALSA: hda: intel-dsp-cfg: Add Chromebook quirk to ADL/RPL

On 8/13/23 20:26, Brady Norander wrote:

AlderLake and RaptorLake Chromebooks currently use the HDA driver by default. Add a quirk to use the SOF driver on these platforms, which is needed for functional internal audio.

that would be wise indeed, I must admit not recalling why this isn't the case. Curtis?

• {

• .flags = FLAG_SOF,
  

• .device = PCI_DEVICE_ID_INTEL_HDA_ADL_PX,
  

Humm, that doesn't seem like a supported configuration, IIRC all the PX skews are for embedded Linux stuff.

• .dmi_table = (const struct dmi_system_id []) {
  

• 	{
  

• 		.ident = "Google Chromebooks",
  

• 		.matches = {
  

• 			DMI_MATCH(DMI_SYS_VENDOR, "Google"),
  

• 		}
  

• 	},
  

• 	{}
  

• }
  

• },

{ .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, .device = PCI_DEVICE_ID_INTEL_HDA_RPL_M, },

• {

• .flags = FLAG_SOF,
  

• .device = PCI_DEVICE_ID_INTEL_HDA_RPL_PX,
  

same here, I don't think we can blindly add quirks.

One might argue it doesn't hurt but not all SKUs are supported by Chrome.

• .dmi_table = (const struct dmi_system_id []) {
  

• 	{
  

• 		.ident = "Google Chromebooks",
  

• 		.matches = {
  

• 			DMI_MATCH(DMI_SYS_VENDOR, "Google"),
  

• 		}
  

• 	},
  

• 	{}
  

• }
  

• }, { .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, .device = PCI_DEVICE_ID_INTEL_HDA_RPL_PX,