Re: [PATCH v2] ASoC: fsi: Add check for clk_enable

Hi Jiasheng

Thank you for your patch

As the potential failure of the clk_enable(), it should be better to check it and return error if fails.

Fixes: ab6f6d85210c ("ASoC: fsi: add master clock control functions") Signed-off-by: Jiasheng Jiang jiasheng@iscas.ac.cn

(snip)

• if (ret)
  

• 	goto err;
  

• ret = clk_enable(clock->ick);
  

• if (ret)
  

• 	goto disable_xck;
  

• ret = clk_enable(clock->div);
  

• if (ret)
  

• 	goto disable_ick;
  
  

  clock->count++; }

  return ret;

+disable_xck:

• clk_disable(clock->xck);

+disable_ick:

• clk_disable(clock->ick);

+err:

• return ret;

}

I think disable_ick() / disable_xck() order are inverted ?

Thank you for your help !!

Best regards --- Kuninori Morimoto