11 Jan
2016
11 Jan
'16
9:02 a.m.
On Mon, 11 Jan 2016 09:00:50 +0100, PC Liao wrote:
@@ -603,7 +606,10 @@ static int mtk_afe_dais_hw_params(struct snd_pcm_substream *substream, if (ret < 0) return ret;
- memif->phys_buf_addr = substream->runtime->dma_addr;
- if (sizeof(dma_addr_t) > 4)
msb_at_bit33 = (substream->runtime->dma_addr & 0x100000000) ? 1 : 0;
Better to put a proper suffix for the constant over 32bit.
Or use upper_32_bits(). Then sizeof() check can be omitted, as the compiler should be smart enough to know it beforehand.
Takashi