Re: [alsa-devel] [PATCH 07/39 v2] ASoC: simple-card-utils: add asoc_simple_card_parse_card_name()

Hi Mark

Thank you for your feedback

...

This function tries to get card name from snd_soc_of_parse_card_name(). and it tries to set card->name from dai_link if card still doesn't have name. So, above is optional 2nd try. Or, do you mean this if (!card->name) can goes to simple-card, instead of utils ? I have no objection about it , but it can be double handling ? Because other simple family have same situation.

If we try to dereference card->dai_link without checking to see if it's set then we'll crash.

Ahh, do you mean we need like this ?

if (!card->name && card->dai_link) card->name = card->dai_link->name;