Re: [alsa-devel] [PATCH 1/2] ALSA: Remove __devinit annotation for pxa2xx_ac97_hw_probe to fix section mismatch warning

On Sun, Feb 19, 2012 at 03:39:18PM +0800, Axel Lin wrote:

This fixes below build warning: WARNING: vmlinux.o(.text+0x1e632c): Section mismatch in reference from the function pxa2xx_ac97_probe() to the function .devinit.text:pxa2xx_ac97_hw_probe() The function pxa2xx_ac97_probe() references the function __devinit pxa2xx_ac97_hw_probe(). This is often because pxa2xx_ac97_probe lacks a __devinit annotation or the annotation of pxa2xx_ac97_hw_probe is wrong.

This seems like the wrong fix - shouldn't we be adding annotations rather than removing them here?