Re: [alsa-devel] [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver

Dne 12. 12. 19 v 10:12 Jeff Chang napsal(a):

+static const struct snd_kcontrol_new mt6660_component_snd_controls[] = {

• SOC_SINGLE_EXT_TLV("Digital Volume", MT6660_REG_VOL_CTRL, 0, 255,

• 	   1, snd_soc_get_volsw, mt6660_component_put_volsw,
  

• 	   vol_ctl_tlv),
  

• SOC_SINGLE_EXT("WDT Switch", MT6660_REG_WDT_CTRL, 7, 1, 0,

•        snd_soc_get_volsw, mt6660_component_put_volsw),
  

• SOC_SINGLE_EXT("Hard_Clip Switch", MT6660_REG_HCLIP_CTRL, 8, 1, 0,

•        snd_soc_get_volsw, mt6660_component_put_volsw),
  

• SOC_SINGLE_EXT("Clip Switch", MT6660_REG_SPS_CTRL, 0, 1, 0,

•        snd_soc_get_volsw, mt6660_component_put_volsw),
  

• SOC_SINGLE_EXT("BoostMode", MT6660_REG_BST_CTRL, 0, 3, 0,

•        snd_soc_get_volsw, mt6660_component_put_volsw),
  

• SOC_SINGLE_EXT("DRE Switch", MT6660_REG_DRE_CTRL, 0, 1, 0,

•        snd_soc_get_volsw, mt6660_component_put_volsw),
  

• SOC_SINGLE_EXT("DC_Protect Switch",

• MT6660_REG_DC_PROTECT_CTRL, 3, 1, 0,
  

• snd_soc_get_volsw, mt6660_component_put_volsw),
  

• SOC_SINGLE_EXT("audio input selection", MT6660_REG_DATAO_SEL, 6, 3, 0,

•        snd_soc_get_volsw, mt6660_component_put_volsw),
  

• SOC_SINGLE_EXT("Data Output Left Channel Selection",

•        MT6660_REG_DATAO_SEL, 3, 7, 0,
  

•        snd_soc_get_volsw, mt6660_component_put_volsw),
  

• SOC_SINGLE_EXT("Data Output Right Channel Selection",

•        MT6660_REG_DATAO_SEL, 0, 7, 0,
  

•        snd_soc_get_volsw, mt6660_component_put_volsw),
  

• /* for debug purpose */
• SOC_SINGLE_EXT("HPF_AUD_IN Switch", MT6660_REG_HPF_CTRL, 0, 1, 0,

•        snd_soc_get_volsw, mt6660_component_put_volsw),
  

• SOC_SINGLE_EXT("AUD_LOOP_BACK Switch", MT6660_REG_PATH_BYPASS, 4, 1, 0,

•        snd_soc_get_volsw, mt6660_component_put_volsw),
  

• SOC_SINGLE_EXT("Mute Switch", MT6660_REG_SYSTEM_CTRL, 1, 1, 0,

•        snd_soc_get_volsw, mt6660_component_put_volsw),
  

• SOC_SINGLE_EXT("Bypass CS Comp Switch", MT6660_REG_PATH_BYPASS, 2, 1, 0,

•        snd_soc_get_volsw, mt6660_component_put_volsw),
  

• SOC_SINGLE_EXT("T0_SEL", MT6660_REG_CALI_T0, 0, 7, 0,

•        snd_soc_get_volsw, NULL),
  

• SOC_SINGLE_EXT("Chip_Rev", SND_SOC_NOPM, 0, 16, 0,

•        mt6660_component_get_volsw, NULL),
  

The control names looks really strange like always for the ASoC tree. We should talk about a standardization here. At least unify spaces, underscores and such characters and abbreviations.

Thanks, Jaroslav