At Mon, 11 Aug 2008 11:42:14 +0100, Mark Brown wrote:
On Mon, Aug 11, 2008 at 12:37:45PM +0200, Takashi Iwai wrote:
You mean both patches (spitz: MONO -> MONO1 and wm8750: add missing VREF)? Anyway, a bit more detailed changelog is needed - what's broken in the real use and how fixed.
The long description is exactly what's broken - the names are wrong or undeclared and since DAPM works based on the control names this causes the drivers to fail to initialise DAPM for the device concerned.
Exactly such a text should appear in the changelog.
It's pretty much equivalent to C code referencing an undeclared variable.
Everyone knows C syntax but not ASoC implementation details. If the patch is pushed to stable tree, it should be described well so that other reviewers can understand it well.
thanks,
Takashi