Switch to use managed variant of acpi_dev_add_driver_gpios() to simplify error path and fix potentially wrong assingment if ->probe() fails.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- sound/soc/intel/boards/bdw-rt5677.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/intel/boards/bdw-rt5677.c b/sound/soc/intel/boards/bdw-rt5677.c index e3aa32c2546b..dc8d18837109 100644 --- a/sound/soc/intel/boards/bdw-rt5677.c +++ b/sound/soc/intel/boards/bdw-rt5677.c @@ -347,8 +347,7 @@ static int bdw_rt5677_probe(struct platform_device *pdev) return -ENOMEM; }
- ret = acpi_dev_add_driver_gpios(ACPI_COMPANION(&pdev->dev), - bdw_rt5677_gpios); + ret = devm_acpi_dev_add_driver_gpios(&pdev->dev, bdw_rt5677_gpios); if (ret) dev_warn(&pdev->dev, "Failed to add driver gpios\n");