Miguel,
Comments below -
<snip>
+config SND_DM365_SOC_EVM
- tristate "SoC Audio support for DaVinci DM365 EVM"
- depends on SND_DAVINCI_SOC && MACH_DAVINCI_DM365_EVM
- select SND_DAVINCI_SOC_I2S
- select SND_SOC_TLV320AIC3X
- help
Say Y if you want to add support for SoC audio on TI
Do you really need a separate Kconfig option for DM365? Can we re-use
the SND_DAVINCI_SOC_EVM for DM6446, DM355 and DM365? I think this would be fine, actually we can reuse more than just SND_DAVINCI_SOC_EVM, we can also reuse evm_snd_devdata because the only difference with DM6446 and DM355 is just the name used in dm365_snd_soc_card_evm. See one more comment below.
Yes, you can now reuse evm_snd_devdata. Earlier we had the i2c_address maintained in this file, so it the structure had to be different for DM365.
<snip>
+/* evm audio subsystem */ static struct snd_soc_device dm6467_evm_snd_devdata = { .card = &dm6467_snd_soc_card_evm, .codec_dev = &soc_codec_dev_aic3x, @@ -249,6 +265,9 @@ static int __init evm_init(void) } else if (machine_is_davinci_dm355_evm()) { evm_snd_dev_data = &evm_snd_devdata; index = 1;
- } else if (machine_is_davinci_dm365_evm()) {
evm_snd_dev_data = &dm365_evm_snd_devdata;
index = 0;
So we can reuse evm_snd_devdata and use it instead of evm_snd_devdata, this is use:
evm_snd_dev_data = &evm_snd_devdata;
instead of:
evm_snd_dev_data = &dm365_evm_snd_devdata;
What do you think about this?
OK, you can change this to reuse the evm_snd_devdata structure.
Thanks Sneha
} else if (machine_is_davinci_dm6467_evm()) { evm_snd_dev_data = &dm6467_evm_snd_devdata; index = 0; -- 1.6.0.4