11 Mar
2014
11 Mar
'14
12:40 a.m.
On Mon, Mar 10, 2014 at 06:15:55PM +0000, Ben Dooks wrote:
+/* wrapper functions to show any errors to updating register values */
+static inline int ak4642_update_bits(struct snd_soc_codec *codec,
unsigned int reg,unsigned int mask, unsigned int val)+{
- int ret = snd_soc_update_bits(codec, reg, mask, val);
- if (ret < 0) {
pr_info("%s: error %d writing %04x (%08x, mask %08x)\n",codec->name, ret, reg, mask, val);
Two things here. One is that this should be a dev_err() and the other is that if this is worth doing shouldn't it just be in the core - I see nothing driver specific here?