On Tue, Jul 05, 2022 at 09:32:07AM +0200, Krzysztof Kozlowski wrote:
On 04/07/2022 18:50, Stephan Gerhold wrote:
Can you check if you can just add the compatibles to the existing qcom,sm8250.yaml? It should be more or less identical given that the DT parsing code in the driver is shared between all these SoCs. I already added the MSM8916 compatibles there a while ago.
It also documents some additional properties ("pin-switches", "widgets") that are supported for SDM845 through the common code but are missing in its binding documentation.
I thought about merging these but then I would have to disallow these properties, as I assumed these are not valid for SDM845. Are you saying that pin-switches and widgets are actually valid for SDM845?
Yes. I haven't tested it but it's implemented in the common DT parsing code and I don't see why it wouldn't work. These are optional properties that are only needed in certain special audio configurations. There might be a SDM845 board out there that needs them. :)
Thanks, Stephan