On Thu, Mar 10, 2016 at 02:12:46PM +0800, John Hsu wrote:
On 3/1/2016 11:26 AM, Mark Brown wrote:
On Mon, Feb 29, 2016 at 03:01:45AM +0800, John Hsu wrote:
+static int nau8825_resume_setup(struct nau8825 *nau8825) +{
I'd expect to see this shared with initial power on?
There is a little things different between resume and initiation. But I think the function could be reused.
Really? Bear in mind the device might have lost power over suspend...
regcache_cache_only(nau8825->regmap, false);
- regcache_sync(nau8825->regmap);
- enable_irq(client->irq);
- enable_irq(nau8825->irq);
We're removing the register cache sync here but I don't see us adding it anywhere else.
A part of suspend and resume action moves to set bias function, nau8825_set_bias_level. We make register cache dirty in bias off; and make register cache sync after resume in bias standby.
OK.