On Thu, 2010-07-22 at 19:43 +0900, Seungwhan Youn wrote:
On Thu, Jul 22, 2010 at 7:15 PM, Liam Girdwood lrg@slimlogic.co.uk wrote:
On Thu, 2010-07-22 at 17:26 +0900, Seungwhan Youn wrote:
>> + return snd_soc_register_dai(dev, drv); > How about s3c64xx-i2s? I think, if this patch fixes all errors in Sorry, I confused your comment. What do you mean "How about s3c64xx-i2s" ?
Actually 'sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.
So, If this patch's purpose is to fix compile error, my opinion is that this patch fix all the same errors in 'sound/soc/s3c24xx/'.
The 'sound/soc/s3c24xx/s3c64xx-i2s.c' haven't directly called 'snd_soc_register_dai()' function. It is call 's3c_i2sv2_register_dai()' in 'sound/soc/s3c24xx/s3c-i2s-v2.c' to register a DAI.
Oh, I was confused about this even I modify this few days ago. I'm sorry that I make you to be confused.
I'm confused too ;)
Is this to be applied or not ?
I think this okay. :)
All applied.
Thanks
Liam