Re: [alsa-devel] [PATCH v2 12/14] ASoC: hdac_hdmi: Add infoframe support for dp audio

On Thu, Dec 03, 2015 at 05:13:16PM +0000, Daniel Stone wrote:

Hi Subhransu,

On 3 December 2015 at 21:09, Subhransu S. Prusty subhransu.s.prusty@intel.com wrote:

...

•   if (conn_type == DRM_ELD_CONN_TYPE_HDMI) {
  

•           hdmi_audio_infoframe_init(&frame);
  

•           /* Default stereo for now */
  

•           frame.channels = channels;
  

•           ret = hdmi_audio_infoframe_pack(&frame, buffer, sizeof(buffer));
  

•           if (ret < 0)
  

•                   return ret;
  

•           dip = (u8 *)&frame;
  

•   } else if (conn_type == DRM_ELD_CONN_TYPE_DP) {
  

•           memset(&dp_ai, 0, sizeof(dp_ai));
  

•           dp_ai.type      = 0x84;
  

•           dp_ai.len       = 0x1b;
  

•           dp_ai.ver       = 0x11 << 2;
  

•           dp_ai.CC02_CT47 = channels - 1;
  

•           dp_ai.CA        = 0;
  

•           dip = (u8 *)&dip;
  

Surely this should be dip = (u8 *) &dp_ai, instead of pointing to itself?

Thanks for pointing. It's a mistake, will fix it.

Regards, Subhansu

Cheers, Daniel

--