On Mon, Nov 2, 2020 at 6:46 PM Tzung-Bi Shih tzungbi@google.com wrote:
On Mon, Nov 2, 2020 at 2:24 PM Ajye Huang ajye.huang@gmail.com wrote:
In addition, having mixer control to switch between DMICs by using "dmic-gpios" property.
Refer to this one as an example, commit b7a742cff3f6 ("ASoC: AMD: Use mixer control to switch between DMICs")
Signed-off-by: Ajye Huang ajye_huang@compal.corp-partner.google.com
I am not sure if it would be better if you use another email (e.g. @gmail) for signoff.
hi, Tzung-Bi Thank you for your review, it's our company's rule to use this PD account
+static int dmic_get(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)+{
struct snd_soc_dapm_context *dapm = snd_soc_dapm_kcontrol_dapm(kcontrol);struct sc7180_snd_data *data = snd_soc_card_get_drvdata(dapm->card);if (data)You don't need to check for NULL. If snd_soc_card_get_drvdata() returns NULL, it shouldn't run into here. See other snd_soc_card_get_drvdata() calls in the file.
your are right, I will remove on v4
+static int dmic_set(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)+{
struct snd_soc_dapm_context *dapm = snd_soc_dapm_kcontrol_dapm(kcontrol);struct sc7180_snd_data *data = snd_soc_card_get_drvdata(dapm->card);if (data) {Ditto.
I will remove it on v4
if (IS_ERR(data->dmic_sel)) {dev_err(&pdev->dev, "DMIC gpio failed err=%d\n",PTR_ERR(data->dmic_sel));return PTR_ERR(data->dmic_sel);Remove 1 level indent.
Your are really attentive, I will remove the indent on v4, thank you so much.