On Mon, Feb 5, 2018 at 4:44 PM, Sylwester Nawrocki s.nawrocki@samsung.com wrote:
The #sound-dai-cells property might be helpful in selecting primary or secondary CPU DAI and it's already present in i2s nodes for some exynos SoCs so let's add it to the DT binding documentation.
The description above looks like you are documenting existing optional property but you added it as a required property.
Best regards, Krzysztof
Signed-off-by: Sylwester Nawrocki s.nawrocki@samsung.com
Documentation/devicetree/bindings/sound/samsung-i2s.txt | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/samsung-i2s.txt b/Documentation/devicetree/bindings/sound/samsung-i2s.txt index 5d7bb2735824..dd1b6e329941 100644 --- a/Documentation/devicetree/bindings/sound/samsung-i2s.txt +++ b/Documentation/devicetree/bindings/sound/samsung-i2s.txt @@ -54,6 +54,9 @@ in the IIS Multi Audio Interface. Note: Old DTs may not have the #clock-cells property and then not use the I2S node as a clock supplier.
- #sound-dai-cells: should be 1.
Optional SoC Specific Properties:
- samsung,idma-addr: Internal DMA register base address of the audio
@@ -79,4 +82,5 @@ i2s0: i2s@3830000 { samsung,idma-addr = <0x03000000>; pinctrl-names = "default"; pinctrl-0 = <&i2s0_bus>;
#sound-dai-cells = <1>;};
2.14.2