Thank you very much for your advice, and I will modify it in the next patch.
On Tue, Sep 12, 2023 at 11:21:22PM -0500, robh@kernel.org wrote:
On Tue, Sep 12, 2023 at 02:58:48PM +0800, wangweidong.a@awinic.com wrote:
From: Weidong Wang wangweidong.a@awinic.com
The subject is still pretty generic. Ideally, we'd never have the same subject twice. I'd do something like this:
ASoC: dt-bindings: awinic,aw88395: Add properties for multiple PA support
Thank you very much. I will modify according to your suggestion in the next patch
Adds properties to "awinic,aw88395" to make files more complete
Complete in what way? multiple PAs, right. It's not really clear to me though how these properties enable support for multiple PAs.
Thank you very much. I will change the following content in the next patch: Add two properties, the "awinic,audio-channel" property and the "awinic,sync-flag". The "awinic,audio-channel" is used to make different PA load different configurations, the "awinic,sync-flag" is used to synchronize the phases of multiple PA. These two properties will be read by the corresponding driver, so that the multi-PA to achieve better playback effect.
Signed-off-by: Weidong Wang wangweidong.a@awinic.com
.../bindings/sound/awinic,aw88395.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml index 4051c2538caf..4965aa4a5370 100644 --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml @@ -32,11 +32,28 @@ properties: reset-gpios: maxItems: 1
- awinic,audio-channel:
- description:
It is used to distinguish multiple PA devices, so that differentconfigurations can be loaded to different PA devices- $ref: /schemas/types.yaml#/definitions/uint32
- minimum: 0
- maximum: 7
- awinic,sync-flag:
- description:
Flag bit used to keep the phase synchronized in the case of multiple PA- $ref: /schemas/types.yaml#/definitions/uint32
- minimum: 0
- maximum: 1
required:
- compatible
- reg
- '#sound-dai-cells'
- reset-gpios
- awinic,audio-channel
- awinic,sync-flag
unevaluatedProperties: false
@@ -51,5 +68,7 @@ examples: reg = <0x34>; #sound-dai-cells = <0>; reset-gpios = <&gpio 10 GPIO_ACTIVE_LOW>;
awinic,audio-channel = <0>;awinic,sync-flag = <0>; };-- 2.41.0