10 Mar
2022
10 Mar
'22
12:29 p.m.
On Thu, Mar 10, 2022 at 08:48:09AM +0000, Sa, Nuno wrote:
- max98390->reset_gpio = of_get_named_gpio(i2c-
dev.of_node,
"maxim,reset-gpios", 0);
Why not using devm_gpiod_get_optional()? We could request the pin already in the asserted state and make the code slightly better...
Yes, and it'd support other firmware interfaces too. We also need an update to the binding document covering the new property.
Might also be worth putting the device into reset when unloading the driver, though that's not essential.