25 Nov
2011
25 Nov
'11
8:02 p.m.
On Friday 25 November 2011 03:59:21 Lars-Peter Clausen wrote:
On 11/24/2011 06:32 PM, Mike Frysinger wrote:
On Thursday 24 November 2011 07:48:25 Lars-Peter Clausen wrote:
- if (crc != le32_to_cpu(ssfw_head->crc)) {
dev_err(&client->dev, "Failed to load firmware: Wrong crc
checksum:"
\ + " expected %x got %x.\n",
it's my understanding that string constants should not be split
I think it is fine here. You probably wouldn't grep for %x anyway.
no, but you would copy and paste a string like: "Failed to load firmware: Wrong crc checksum: expected" and then not find a match
i think it's best to follow the style anyways ...
also, no need for the period at the end of the msg. that's useless noise and can be annoying to copying & pasting numbers. -mike