On Wed, Oct 29, 2014 at 06:45:05AM +0000, Lin, Mengdong wrote:
Nothing ever stops the PLL - a set_bias_level() callback with a handler for _OFF. Otherwise we're wasting power.
Can we introduce a power supply widget for the platform clock used as MCLK? That widget can be added into the playback and capture path. So when idle, the platform clock can be turn off and let the codec PLL selects its internal low frequency clock only for jack detection. It's verified internally.
That should be fine also, it's just usually a bit more work to add all the routes for DAPM.
Or we don't change the code at moment, until we upstream the platform clock driver at first?
Which way is better?
Well, currently the code to load the driver is also not upstream so may as well have the driver be what's wanted! But it's not a massive deal, main thing would be to get everything done as part of initial upstreaming instead of having to come back and work on it again later.