Re: [alsa-devel] [PATCH v4 1/3] ECI: input: introduce ECI accessory input driver

Hi Tapio,

On Wed, Jan 19, 2011 at 02:06:54PM +0200, tapio.vihuri@nokia.com wrote:

• for (; key->type != KE_END; key++) {

• switch (key->type) {
  

• case KE_KEY:
  

• 	__set_bit(key->keycode, eci->acc_input->keybit);
  

• 	break;
  

• case KE_SW:
  

• case KE_VSW:
  

• 	__set_bit(key->keycode, eci->acc_input->swbit);
  

• 	break;
  

• }
  

• }

Is this still needed? I believe sparse_keymap_setup() below shoudl take care of this...

• __set_bit(EV_KEY, eci->acc_input->evbit);
• __set_bit(EV_SW, eci->acc_input->evbit);
• __set_bit(EV_REP, eci->acc_input->evbit);
• err = sparse_keymap_setup(eci->acc_input, eci_keymap, NULL);
• if (err)

• goto err_free_dev;
  

Haven't looked at the rest yet...

Thanks.