Hi Alejandro,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on asoc/for-next] [also build test ERROR on v5.14-rc7 next-20210827] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alejandro-Tafalla/Add-reset-gpios-h... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next config: hexagon-randconfig-r013-20210829 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 510e106fa8635e7f9c51c896180b971de6309b2f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4cc91cc4ff05ef061e2247a49c8b7cf9084f... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Alejandro-Tafalla/Add-reset-gpios-handling-for-max98927/20210830-010941 git checkout 4cc91cc4ff05ef061e2247a49c8b7cf9084fe6fb # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=hexagon SHELL=/bin/bash sound/soc/codecs/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
sound/soc/codecs/max98927.c:912:22: error: expected ';' after expression
usleep_range(5, 10) ^ ; sound/soc/codecs/max98927.c:914:21: error: expected ';' after expression usleep_range(1, 5) ^ ; 2 errors generated.
vim +912 sound/soc/codecs/max98927.c
867 868 int ret = 0, value; 869 int reg = 0; 870 struct max98927_priv *max98927 = NULL; 871 872 max98927 = devm_kzalloc(&i2c->dev, 873 sizeof(*max98927), GFP_KERNEL); 874 875 if (!max98927) { 876 ret = -ENOMEM; 877 return ret; 878 } 879 i2c_set_clientdata(i2c, max98927); 880 881 /* update interleave mode info */ 882 if (!of_property_read_u32(i2c->dev.of_node, 883 "interleave_mode", &value)) { 884 if (value > 0) 885 max98927->interleave_mode = true; 886 else 887 max98927->interleave_mode = false; 888 } else 889 max98927->interleave_mode = false; 890 891 /* regmap initialization */ 892 max98927->regmap 893 = devm_regmap_init_i2c(i2c, &max98927_regmap); 894 if (IS_ERR(max98927->regmap)) { 895 ret = PTR_ERR(max98927->regmap); 896 dev_err(&i2c->dev, 897 "Failed to allocate regmap: %d\n", ret); 898 return ret; 899 } 900 901 max98927->reset_gpio 902 = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_HIGH); 903 if (IS_ERR(max98927->reset_gpio)) { 904 ret = PTR_ERR(max98927->reset_gpio); 905 dev_err(&i2c->dev, 906 "Failed to request GPIO reset pin, error %d\n", ret); 907 return ret; 908 } 909 910 if (max98927->reset_gpio) { 911 gpiod_set_value_cansleep(max98927->reset_gpio, 0);
912 usleep_range(5, 10)
913 gpiod_set_value_cansleep(max98927->reset_gpio, 1); 914 usleep_range(1, 5) 915 } 916 917 /* Check Revision ID */ 918 ret = regmap_read(max98927->regmap, 919 MAX98927_R01FF_REV_ID, ®); 920 if (ret < 0) { 921 dev_err(&i2c->dev, 922 "Failed to read: 0x%02X\n", MAX98927_R01FF_REV_ID); 923 return ret; 924 } 925 dev_info(&i2c->dev, "MAX98927 revisionID: 0x%02X\n", reg); 926 927 /* voltage/current slot configuration */ 928 max98927_slot_config(i2c, max98927); 929 930 /* codec registeration */ 931 ret = devm_snd_soc_register_component(&i2c->dev, 932 &soc_component_dev_max98927, 933 max98927_dai, ARRAY_SIZE(max98927_dai)); 934 if (ret < 0) 935 dev_err(&i2c->dev, "Failed to register component: %d\n", ret); 936 937 return ret; 938 } 939
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org