On Tue, Oct 27, 2020 at 11:33:49AM +0530, Sameer Pujar wrote:
Hi Morimoto-san,
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
This patch switches from .txt base to .yaml base Document.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
(snip)
Since I am trying to re-use most of audio-graph for Tegra, can 'compatible' be moved to a separate schema? For example, audio-graph.yaml -> defines all the common stuff audio-graph-card.yaml -> audio-graph.yaml + 'compatible' property Similarly, tegra-audio-graph-card.yaml -> audio-graph.yaml + Tegra 'compatible' property
I'm not expert of Json-Schema, and it sound very expert technique for me. (It always indicates me unknown errors...) I'm posting this patch since many month ago, and not yet accepted for many reasons (audio-graph DT is very complex). I spend many times for it and finally come to the point where it can (might) be accepted. I'm sorry but I want to finish this work, this means I don't want to customize it any more. If I try it, it needs more month...
I am not a json-schema expert either :) From earlier comments on Tegra audio graph series, above re-use is possible I suppose. I depend on your audio-graph documentation and for 'compatible' I am seeing error. So I thought it may be fine to split audio-graph into two json-schemas now itself. Otherwise I need to do it separately in my series if I want to re-use your audio-graph, which is fine with me.
I think this part must be sorted out. Defining the graph schema could come later though.
With compatible dropped from audio-graph.yaml, audio-graph-scu-card.yaml would look like this:
allOf: - $ref: audio-graph.yaml
properties: compatible: const: audio-graph-scu-card
unevaluatedProperties: false
However, What is 'audio-graph-scu-card' supposed to mean compared to 'audio-graph-card'. It's never used by the driver or in any dts file.
Rob