27 Apr
2020
27 Apr
'20
1:22 p.m.
On Mon, Apr 27, 2020 at 09:48:32AM +0200, Marek Szyprowski wrote:
Don't confuse user with meaningless warning about the failure in getting clocks in case of deferred probe.
if (ret < 0) {
dev_err(&pdev->dev, "Failed to get clocks: %d\n", ret);
if (ret != -EPROBE_DEFER)dev_err(&pdev->dev, "Failed to get clocks: %d\n", ret);
This completely eliminates the diagnostics which means that if the clock isn't there the user is a bit stuck trying to work out what's missing. There should still be a diagnostic.