'Twas brillig, and Takashi Iwai at 22/10/10 15:03 did gyre and gimble:
At Fri, 22 Oct 2010 13:31:53 +0200, Clemens Ladisch wrote:
Jiri Slaby wrote:
On 10/21/2010 10:05 AM, Takashi Iwai wrote:
commit de8c85f7840e5e29629de95f5af24297fb325e0b ALSA: HDA: Sigmatel: work around incorrect master muting
Reverting this one helps.
This one introduced even more wrong volume information on some codecs. Pleasy try this patch on top:
Argh! There is always a reason why we should define a constant. I applied the fix now.
This explains why the old patch worked on Colin's machine. His codec chip is different (STAC9200?), and it doesn't go in this code path but has a static Master volume creation.
Yup I have a STAC9200 so that explains it... silly me as I did see this line and figured "the value will be right" rather than questioning it.
Anyway, glad this has been found and there is now (presumably) no need for a revert :)
Col