On Wed, Apr 12, 2017 at 09:41:01AM +0200, Takashi Iwai wrote:
On Wed, 12 Apr 2017 07:45:20 +0200, Takashi Iwai wrote:
On Tue, 11 Apr 2017 15:31:37 +0200, Takashi Iwai wrote:
On Wed, 05 Apr 2017 11:07:14 +0200, <simon.ho.cnxt@gmail.com> wrote:
--- /dev/null +++ b/sound/soc/codecs/cx2072x.c +/** + * cx2072x_enable_detect - Enable CX2072X jack detection + * @codec : pointer variable to codec having information related to codec + * + */ +int cx2072x_enable_detect(struct snd_soc_codec *codec) +{
.....
+} +EXPORT_SYMBOL_GPL(cx2072x_enable_detect); + +/* + * cx2072x_get_jack_state: Return current jack state. + * @codec : pointer variable to codec having information related to codec + * + */ +int cx2072x_get_jack_state(struct snd_soc_codec *codec) +{ .... +} +EXPORT_SYMBOL_GPL(cx2072x_get_jack_state); --- /dev/null +++ b/sound/soc/codecs/cx2072x.h .... +enum cx2072x_jack_types { + CX_JACK_NONE = 0x0000, + CX_JACK_HEADPHONE = 0x0001, + CX_JACK_APPLE_HEADSET = 0x0002, + CX_JACK_NOKIE_HEADSET = 0x0003, +}; + +int cx2072x_hs_jack_report(struct snd_soc_codec *codec);
This function is nowhere defined. And the new jack functions cx2072x_enable_detect() and cx2072x_get_jack_state() are not declared here, either.
Also, some DAPM entries are missing / wrong, obviously.
... and yet another missing ones, the powers for some pins aren't hooked.
Takashi
You are right, thanks for caching that. Simon
--- a/sound/soc/codecs/cx2072x.c +++ b/sound/soc/codecs/cx2072x.c @@ -1737,6 +1737,10 @@ static const struct snd_soc_dapm_route cx2072x_intercon[] = { {"Out AIF", NULL, "I2S ADC2R"}, {"Out AIF", NULL, "AFG Power"}, {"AEC REF", NULL, "Out AIF"}, + {"PortB In En", NULL, "PortB Power"}, + {"PortC In En", NULL, "PortC Power"}, + {"PortD In En", NULL, "PortD Power"}, + {"PortE In En", NULL, "PortE Power"}, };
static void cx2072x_sw_reset(struct cx2072x_priv *cx2072x)