Re: Semantics for _SX controls

On Wed, Jun 01, 2022 at 06:14:47PM +0100, Srinivas Kandagatla wrote:

From Qualcomm codecs side of it usage of SOC_SINGLE_SX_TLV should be moved to SOC_SINGLE_S8_TLV() in sound/soc/codecs/msm8916-wcd-digital.c and sound/soc/codecs/wcd9335.c. using SOC_SINGLE_SX_TLV() will result in incorrect volume settings.

All of these gains have signed 7th bit in 8 bit register with gain range from -84dB to +40dB in 1dB steps.

Other WCD Codecs seems to have done correctly using S8_TLV.

I can send a patch to fix these.

Sounds good, thanks for checking.