Re: [alsa-devel] [PATCH] ASoC: Accept any logical value WM8903 GPIO set()

On Mon, 2011-01-31 at 13:42 +0000, Mark Brown wrote:

Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com

sound/soc/codecs/wm8903.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c index 54383c3..27cd8f5 100644 --- a/sound/soc/codecs/wm8903.c +++ b/sound/soc/codecs/wm8903.c @@ -1904,7 +1904,8 @@ static void wm8903_gpio_set(struct gpio_chip *chip, unsigned offset, int value) struct snd_soc_codec *codec = wm8903->codec;

snd_soc_update_bits(codec, WM8903_GPIO_CONTROL_1 + offset,

• 	    WM8903_GP1_LVL_MASK, value << WM8903_GP1_LVL_SHIFT);
  

• 	    WM8903_GP1_LVL_MASK,
  

• 	    !!value << WM8903_GP1_LVL_SHIFT);
  

}

static struct gpio_chip wm8903_template_chip = {

Acked-by: Liam Girdwood lrg@slimlogic.co.uk