Re: [PATCH] ALSA: hda/i915: Fix one too many pci_dev_put()

19 Apr 2022


      On Sat, 16 Apr 2022 08:44:18 +0200,
Lucas De Marchi wrote:
...
pci_get_class() will already unref the pci device passed as argument.
So if it's unconditionally unref'ed, even if the loop is not stopped,
there will be one too many unref for each device not matched.
Cc: Kai Vehmanen kai.vehmanen@linux.intel.com
Cc: Takashi Iwai tiwai@suse.de
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5701
Fixes: 0dc2696a4623 ("ALSA: hda/i915 - skip acomp init if no matching display")
Signed-off-by: Lucas De Marchi lucas.demarchi@intel.com
Thanks, applied now.
But the Fixes commit id was wrong.  I corrected to the right upstream
one, c9db8a30d9f0.
Takashi