On Thu, Feb 16, 2017 at 7:32 PM, Michał Kępień kernel@kempniu.pl wrote:
The led stops working after 4th patch "platform/x86: dell-laptop: import dell_micmute_led_set() from drivers/leds/dell-led.c", and the .config is with CONFIG_DELL_LAPTOP=m
However, I found dell-laptop is not loaded on Latitude 7480 as its chassis type is Notebook (10), instead of 8 (Portable) or 9 (Laptop). That's also what I see for newer Dell laptops.
After I added the below entry into dell-laptop, the led works fine. This is not in kernel 4.10 rc8 either, and I will submit a patch for it.
{ .matches = { DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /*Notebook*/ }, },Great, so it all makes sense now. Thanks once again for investigating.
For maintainers' convenience, I am planning to submit a v3 with all the tags supplied by everyone who reviewed this series and also some minor coding style tweaks suggested along the way.
Alex, in the light of your findings quoted above, would it be okay to also apply your Tested-by to all patches?
Certainly.
Tested-by: Alex Hung alex.hung@canonical.com
Jacek, Pavel, which linux-leds branch would you like me to base v3 on?
-- Best regards, Michał Kępień