On Sun, Jun 27, 2010 at 12:12:05AM +0300, Vasily Khoruzhick wrote:
В сообщении от 26 июня 2010 23:57:42 автор Mark Brown написал:
You definitely should be doing this in the I2C driver not the CODEC driver, you're peering inside the internals of the I2C driver as things stand and are likely to cause problems if someone comes along and implements this in the driver. There's also the fact that all users of the I2C controller will benefit if the code is implemented there, not just this one audio driver.
I'm afraid that it can cause problems with other i2c-controlled devices, and I
That's still not dealing with the problems that will arise if someone does implement this in the core. To be honest I'm having a hard time seeing why devices would care - the I2C controller only clocks the bus during a transfer and otherwise produces no output - so it should just be an issue for the controller IP.
can test i2c modification only on h1940 and rx1950 with same codec (uda1380).
Nobody is ever going to be able to test on all possible hardware, testing is a community effort.