Re: [PATCH] ASoC: dt-bindings: nau8315: Convert to dtschema

On 16/05/2023 07:49, David Lin wrote:

Convert the NAU8315 audio CODEC bindings to DT schema.

Signed-off-by: David Lin CTLIN0@nuvoton.com

+allOf:

• • $ref: dai-common.yaml#

+properties:

• compatible:
• enum:

•  - nuvoton,nau8315
  

•  - nuvoton,nau8318
  

• '#sound-dai-cells':
• const: 0
• enable-gpios:
• maxItems: 1
• description:

•  GPIO specifier for the chip's device enable input(EN) pin.
  

•  If this option is not specified then driver does not manage
  

•  the pin state (e.g. chip is always on).
  

The only thing driver is doing is to toggle this pin. If it is missing the entire driver is noop, thus above comment is a bit funny. It probably should be mandatory pin. But I see it was there since beginning so ok.

Reviewed-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org

Best regards, Krzysztof