On Mon, Jan 6, 2020 at 10:55 PM Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com wrote:
On 12/11/19 4:59 AM, Jon Hunter wrote:
On 10/12/2019 19:52, Arnd Bergmann wrote:
When CONFIG_SPI is disabled, the newly added code for the DSP firmware loading fails to link:
ERROR: "rt5677_spi_hotword_detected" [sound/soc/codecs/snd-soc-rt5677.ko] undefined! ERROR: "rt5677_spi_write" [sound/soc/codecs/snd-soc-rt5677.ko] undefined!
Would it be better if the above functions or the functions that call these are conditional on CONFIG_SND_SOC_RT5677_SPI?
they are already conditional, with a fallback provided:
#if IS_ENABLED(CONFIG_SND_SOC_RT5677_SPI) int rt5677_spi_read(u32 addr, void *rxbuf, size_t len);
Right, this fixed the problem.
in theory if SPI is not enabled the fallback static inlines would always be selected?
Arnd, if you can share the .config that exposes this problem it'd be nice
I just tried it again and it seems that the issue was already fixed by commit fb3194413d1e ("ASoC: rt5677: Fix build error without CONFIG_SPI"), which had not been merged by the time I created my patch as an alternative workaround.
Arnd