On 2015-03-20 16:39, Jie Yang wrote:
Currently only hda will create kctls for hda jacks, for asoc, people may need create jack kctls in specific driver.
Here we are introducing kctls for each jack, by creating kctls and add them to jack controls list (considering exist of combo jack). At the same time, we will report events for each control in the list.
With this implement, we are no longer need hda jack specific kctls, so here also remove jack kctls for hda.
Hmm, I must have missed this. It's great that you try to implement kctl jacks for ASoC, but your actual implementation seems to regress HDA, unless I'm missing something.
In particular, the phantom jacks currently show up in the kctl jack layer only, not in the /dev/input layer, and I prefer to keep it that way in order not to pollute the /dev/input layer with phantom jacks. But it looks like these will just disappear (?!) with your patch, but I'm not entirely sure. Could you elaborate?