Hi Stefan,
kernel test robot noticed the following build errors:
[auto build test ERROR on tiwai-sound/for-next] [also build test ERROR on tiwai-sound/for-linus linus/master next-20230908] [cannot apply to v6.5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Stefan-Binding/ALSA-hda-cs35l... base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next patch link: https://lore.kernel.org/r/20230908133421.2483508-2-sbinding%40opensource.cir... patch subject: [PATCH v2 1/2] ALSA: hda: cs35l41: Support mute notifications for CS35L41 HDA config: x86_64-buildonly-randconfig-002-20230909 (https://download.01.org/0day-ci/archive/20230909/202309090456.mBm0zTlw-lkp@i...) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230909/202309090456.mBm0zTlw-lkp@i...)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot lkp@intel.com | Closes: https://lore.kernel.org/oe-kbuild-all/202309090456.mBm0zTlw-lkp@intel.com/
All errors (new ones prefixed by >>):
sound/pci/hda/patch_realtek.c:6718:31: error: call to undeclared function 'acpi_device_handle'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
spec->comps[i].acpi_notify(acpi_device_handle(spec->comps[i].adev), event, ^
sound/pci/hda/patch_realtek.c:6718:31: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'acpi_handle' (aka 'void *') [-Wint-conversion]
spec->comps[i].acpi_notify(acpi_device_handle(spec->comps[i].adev), event, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sound/pci/hda/patch_realtek.c:6737:7: error: call to undeclared function 'acpi_device_handle'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] if (!acpi_device_handle(adev)) ^
sound/pci/hda/patch_realtek.c:6745:41: error: incomplete definition of type 'struct acpi_device'
ret = acpi_install_notify_handler(adev->handle, ACPI_DEVICE_NOTIFY, ~~~~^ include/linux/acpi.h:790:8: note: forward declaration of 'struct acpi_device' struct acpi_device; ^ sound/pci/hda/patch_realtek.c:6766:7: error: call to undeclared function 'acpi_device_handle'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] if (!acpi_device_handle(adev)) ^ sound/pci/hda/patch_realtek.c:6769:39: error: incomplete definition of type 'struct acpi_device' ret = acpi_remove_notify_handler(adev->handle, ACPI_DEVICE_NOTIFY, ~~~~^ include/linux/acpi.h:790:8: note: forward declaration of 'struct acpi_device' struct acpi_device; ^ 6 errors generated.
vim +/acpi_device_handle +6718 sound/pci/hda/patch_realtek.c
6707 6708 static void comp_acpi_device_notify(acpi_handle handle, u32 event, void *data) 6709 { 6710 struct hda_codec *cdc = data; 6711 struct alc_spec *spec = cdc->spec; 6712 int i; 6713 6714 codec_info(cdc, "ACPI Notification %d\n", event); 6715 6716 for (i = 0; i < HDA_MAX_COMPONENTS; i++) { 6717 if (spec->comps[i].dev && spec->comps[i].acpi_notify)
6718 spec->comps[i].acpi_notify(acpi_device_handle(spec->comps[i].adev), event,
6719 spec->comps[i].dev); 6720 } 6721 } 6722 6723 static int comp_bind(struct device *dev) 6724 { 6725 struct hda_codec *cdc = dev_to_hda_codec(dev); 6726 struct alc_spec *spec = cdc->spec; 6727 struct acpi_device *adev; 6728 bool support_notifications = false; 6729 int ret; 6730 int i; 6731 6732 ret = component_bind_all(dev, spec->comps); 6733 if (ret) 6734 return ret; 6735 6736 adev = spec->comps[0].adev; 6737 if (!acpi_device_handle(adev)) 6738 return 0; 6739 6740 for (i = 0; i < HDA_MAX_COMPONENTS; i++) 6741 support_notifications = support_notifications || 6742 spec->comps[i].acpi_notifications_supported; 6743 6744 if (support_notifications) {
6745 ret = acpi_install_notify_handler(adev->handle, ACPI_DEVICE_NOTIFY,
6746 comp_acpi_device_notify, cdc); 6747 if (ret < 0) { 6748 codec_warn(cdc, "Failed to install notify handler: %d\n", ret); 6749 return 0; 6750 } 6751 6752 codec_dbg(cdc, "Notify handler installed\n"); 6753 } 6754 6755 return 0; 6756 } 6757