On 7/30/21 9:05 AM, Cezary Rojewski wrote:
On 2021-07-30 3:55 PM, Pierre-Louis Bossart wrote:
On 7/30/21 6:59 AM, Lukasz Majczak wrote:
...
@@ -113,7 +113,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_kbl_machines[] = { }, { .id = "DLGS7219", - .drv_name = "kbl_da7219_mx98373", + .drv_name = "kbl_da7219_max98373",
this one is wrong though? The correct name was already present, you're reverting back to the wrong name.
there's another one that I missed, do you mind changing this as well?
soc-acpi-intel-cml-match.c: .drv_name = "cml_da7219_max98357a",
Should be "cml_da7219_mx98357a"
Not saying 'nay' or 'yay' but why is configuration first available on KBL platforms being renamed to 'cml_XXX'?
The same bxt_da7219_max98357a.c machine driver is used for multiple devices.
static const struct platform_device_id bxt_board_ids[] = { { .name = "bxt_da7219_mx98357a" }, { .name = "glk_da7219_mx98357a" }, { .name = "cml_da7219_mx98357a" }, { } }; MODULE_DEVICE_TABLE(platform, bxt_board_ids);
Why there are different drivers for KBL and BXT is probably lost in history.