22 Mar
2013
22 Mar
'13
11:26 a.m.
On Thu, Mar 21, 2013 at 11:04:05PM -0600, Stephen Warren wrote:
On 03/21/2013 07:19 PM, Kuninori Morimoto wrote:
However, I do see:
./mpc8610_hpcd.c:213: machine_data->dai[0].cpu_dai_name = dev_name(&ssi_pdev->dev); ./p1022_ds.c:223: mdata->dai[0].cpu_dai_name = dev_name(&ssi_pdev->dev); ./p1022_rdk.c:226: mdata->dai[0].cpu_dai_name = dev_name(&ssi_pdev->dev); ./imx-sgtl5000.c:151: data->dai.cpu_dai_name = dev_name(&ssi_pdev->dev);
That's a bit icky; DT-based systems should use .cpu_of_node, not .cpu_dai_name...
With the exception of the SGTL5000 one those are all very old school ASoC DT drivers that predate any framework involvement or review outside of the driver.