30 Apr
2024
30 Apr
'24
3:45 p.m.
On Tue, Apr 30, 2024 at 02:58:10PM +0200, Takashi Iwai wrote:
On Tue, 30 Apr 2024 09:25:42 +0200, Baojun Xu wrote:
...
snd-hda-cs-dsp-ctls-objs := hda_cs_dsp_ctl.o snd-hda-scodec-component-objs := hda_component.o snd-hda-scodec-tas2781-i2c-objs := tas2781_hda_i2c.o +snd-hda-scodec-tas2781-spi-y := tas2781_hda_spi.o tas2781_spi_fwlib.o
A nitpicking: better to align with other lines (i.e. with *-objs instead of *-y).
I object this. The better approach is to have a precursor patch that switches to y over objs (the latter is for user space code / tools).
--
With Best Regards,
Andy Shevchenko