Re: [PATCH v4 1/2] ASoC: amd: Add support for RT5682 codec in machine driver

On Thu, Mar 18, 2021 at 02:03:46AM +0530, Vijendar Mukunda wrote:

+++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -1,27 +1,8 @@ -/*

• • Machine driver for AMD ACP Audio engine using DA7219 & MAX98357 codec
• • Copyright 2017 Advanced Micro Devices, Inc.

The conversion to SPDX really feels like it should at least be called out in the changelog, and probably a separate change.

• /*

• * Set wclk to 48000 because the rate constraint of this driver is
  

• * 48000. ADAU7002 spec: "The ADAU7002 requires a BCLK rate that is
  

• * minimum of 64x the LRCLK sample rate." RT5682 is the only clk
  

• * source so for all codecs we have to limit bclk to 64X lrclk.
  

• */
  

• clk_set_rate(rt5682_dai_wclk, 48000);
• clk_set_rate(rt5682_dai_bclk, 48000 * 64);

The driver should really check the return value of clk_set_rate(), it can fail.