On Mon, 28 Feb 2022 17:39:21 +0100, Joe Perches wrote:
On Mon, 2022-02-28 at 17:02 +0100, Takashi Iwai wrote:
On Mon, 28 Feb 2022 06:20:45 +0100, Joe Perches wrote:
On Mon, 2022-02-28 at 13:02 +0800, Meng Tang wrote:
Return the result from file->f_op->open() directly instead of taking this in another redundant variable. Make the typical return the last statement, return early and reduce the indentation too.
Signed-off-by: Meng Tang tangmeng@uniontech.com Signed-off-by: Joe Perches joe@perches.com
Hi Meng Tang.
For the next time: it's not necessary (or even good) to add a sign-off for another person unless they specifically authorize one.
You wrote and are submitting these changes, I merely gave you simple suggestions as to how you could improve them.
Joe, would you like to drop your S-o-b lines from those two patches? Or shall I keep them?
thanks,
Takashi
Hi Takashi.
Nominally, the sign-off-by chain shows who pushed these changes upstream and I did not and I am not an upstream aggregator.
But whatever you choose is OK. It's not really a concern to me. I do think these changes are ok.
OK, I dropped S-o-b lines and applied the patches now.
thanks,
Takashi