On Thu, 11 May 2017 11:15:11 +0200, Christoph Hellwig wrote:
On Thu, May 11, 2017 at 10:46:47AM +0200, Takashi Iwai wrote:
Yeah, I also started looking at it after reading the LWN article. The removal of set_fs() in ALSA part was already finished, and I'm currently brushing up the patches. It'll be in 4.13 at latest.
Great!
That said, I'd love to drop that legacy stuff; or maybe as a soft-landing, begin with disabling the build of sound/oss in Kconfig.
The latter can be done even for 4.12, if Linus doesn't mind.
I'd be absolutely in favor of trying that and seeing if anyone screams.
Since no one cried against it so far, I'll try to smuggle the following patch into 4.12.
Takashi
-- 8< -- From: Takashi Iwai tiwai@suse.de Subject: [PATCH] sound: Disable the build of OSS drivers
OSS drivers are left as badly unmaintained, and now we're facing a problem to clean up the hackish set_fs() usage in their codes. Since most of drivers have been covered by ALSA, and the others are dead old and inactive, let's leave them RIP.
This patch is the first step: disable the build of OSS drivers. We'll eventually drop the whole codes and clean up later.
Signed-off-by: Takashi Iwai tiwai@suse.de --- sound/Kconfig | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/sound/Kconfig b/sound/Kconfig index ee2e69a9ecd1..41eda578d08e 100644 --- a/sound/Kconfig +++ b/sound/Kconfig @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
If unsure, say Y.
-source "sound/oss/dmasound/Kconfig" +### TO-BE-REMOVED +# source "sound/oss/dmasound/Kconfig"
if !M68K && !UML
@@ -112,17 +113,18 @@ source "sound/x86/Kconfig"
endif # SND
-menuconfig SOUND_PRIME - tristate "Open Sound System (DEPRECATED)" - select SOUND_OSS_CORE - help - Say 'Y' or 'M' to enable Open Sound System drivers. - -if SOUND_PRIME - -source "sound/oss/Kconfig" - -endif # SOUND_PRIME +### TO-BE-REMOVED +# menuconfig SOUND_PRIME +# tristate "Open Sound System (DEPRECATED)" +# select SOUND_OSS_CORE +# help +# Say 'Y' or 'M' to enable Open Sound System drivers. +# +# if SOUND_PRIME +# +# source "sound/oss/Kconfig" +# +# endif # SOUND_PRIME
endif # !M68K