25 Sep
2015
25 Sep
'15
7:50 p.m.
On Fri, Sep 25, 2015 at 04:21:27PM +0200, Gianluca Renzi wrote:
snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL, SGTL5000_BIAS_R_MASK,
sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT);
sgtl5000->micbias_voltage << SGTL5000_BIAS_VOLT_SHIFT);
That doesn't look right... I would expect _BIAS_R_SHIFT to shift a value into the register masked off by _BIAS_R_MASK and therefore that the above is saying that the definition of one of those two macros is wrong. I would not expect something called _BIAS_VOLT_SHIFT here.
What's going on here?
@@ -1549,7 +1549,7 @@ static int sgtl5000_i2c_probe(struct i2c else { sgtl5000->micbias_voltage = 0; dev_err(&client->dev,
"Unsuitable MicBias resistor\n");
"Unsuitable MicBias voltage\n"); }
This looks like a reasonable but unrelated fix and should be in a separate patch.